Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify what is supported in NODE_OPTIONS #52076

Closed
wants to merge 2 commits into from
Closed

doc: clarify what is supported in NODE_OPTIONS #52076

wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Mar 13, 2024
aduh95
aduh95 reviewed Mar 13, 2024
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
@mhdawson @aduh95
Update doc/api/cli.md
d352155 
Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 14, 2024
UlisesGascon
UlisesGascon approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mhdawson added a commit that referenced this pull request Mar 22, 2024
@mhdawson
doc: clarify what is supported in NODE_OPTIONS
3fcaf7b 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
@mhdawson
Copy link
Member Author

Landed in 3fcaf7b

@mhdawson mhdawson closed this Mar 22, 2024
anonrig pushed a commit to anonrig/node that referenced this pull request Mar 25, 2024
@mhdawson @anonrig
doc: clarify what is supported in NODE_OPTIONS
8388355 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#52076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@mhdawson @rdw-msft
doc: clarify what is supported in NODE_OPTIONS
cd2925d 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#52076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@mhdawson @marco-ippolito
doc: clarify what is supported in NODE_OPTIONS
910911e 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@mhdawson @marco-ippolito
doc: clarify what is supported in NODE_OPTIONS
4f19203 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52076
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhdawson @lpinca @UlisesGascon @aduh95 @nodejs-github-bot